util: don't throw when obj.inspect() returns a non-string value

Fixes nodejs#410.
bnoordhuis · Sep 6, 2011 · 4cf91ed · 4cf91ed · TooTallNate · Nov 30, 2011
1 parent 4cf0ce5
commit 4cf91ed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/util.js b/lib/util.js
@@ -144,7 +144,7 @@ function inspect(obj, showHidden, depth, colors) {
         value !== exports &&
         // Also filter out any prototype objects using the circular check.
         !(value.constructor && value.constructor.prototype === value)) {
-      return value.inspect(recurseTimes);
+      return '' + value.inspect(recurseTimes);
     }
 
     // Primitive types cannot have properties

diff --git a/test/simple/test-util-inspect.js b/test/simple/test-util-inspect.js
@@ -33,3 +33,11 @@ var orig = util.inspect(d);
 Date2.prototype.foo = 'bar';
 var after = util.inspect(d);
 assert.equal(orig, after);
+
+// .inspect() function that returns a non-string
+// should not trigger an exception
+// https://github.com/joyent/node/issues/410
+var o = {
+  inspect: function() {}
+};
+assert.equal(util.inspect(o), 'undefined');