New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [[Call]] to String #100

Closed

jasonwilliams opened this issue Sep 8, 2019 · 0 comments

Labels

good first issue Hacktoberfest

Member

jasonwilliams commented Sep 8, 2019 •

edited

This should be an easy one..
String has a [[Construct]] method which returns a string instance. This is working fine.
The [[Call]] version should return a native string.
https://github.com/jasonwilliams/boa/blob/master/src/lib/js/string.rs#L529-L532

For inspiration, see how Boolean works:
https://github.com/jasonwilliams/boa/blob/master/src/lib/js/boolean.rs#L53-L54

It might be hard to test for now, as the executor currently doesn't use [[Call]]

Spec

https://tc39.es/ecma262/#sec-string-constructor-string-value

jasonwilliams added good first issue Hacktoberfest labels

jasonwilliams mentioned this issue

Implementing native returns for constructor functions #10

Closed

1 task

jasonwilliams closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment