Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks are failing in master #322

Closed
Razican opened this issue Apr 16, 2020 · 0 comments · Fixed by #323
Closed

Benchmarks are failing in master #322

Razican opened this issue Apr 16, 2020 · 0 comments · Fixed by #323
Labels
bug Something isn't working E-Easy Easy
Milestone
v0.8.0

Comments

@Razican
Copy link
Member

Razican commented Apr 16, 2020

Since the v0.7.0 release, all benchmarks are failing in master (link). The error it gives is that the Cargo.lock file would be overwritten by the clone. This seems related to the version change in Cargo.toml, if we didn't do a cargo update just after.

So I think the solution is to just do a cargo update and commit.
@Razican Razican added bug Something isn't working E-Easy Easy labels Apr 16, 2020
@Razican Razican added this to the v0.8.0 milestone Apr 16, 2020
@Razican Razican mentioned this issue Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working E-Easy Easy
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Added more benchmarks boa-dev/boa
1 participant
@Razican