We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 2018 edition removed the need for the try macro, functions which return an Option/Result can be used with the ? operator.
try
?
More info here: https://doc.rust-lang.org/stable/edition-guide/rust-2018/error-handling-and-panics/the-question-mark-operator-for-easier-error-handling.html
Book: https://doc.rust-lang.org/beta/book/ch09-02-recoverable-errors-with-result.html#a-shortcut-for-propagating-errors-the--operator
Boa still has try! all over the place for e.g https://github.com/jasonwilliams/boa/blob/master/src/lib/js/value.rs#L507
try!
These could be converted to use the ? operator instead. e.g https://github.com/jasonwilliams/boa/blob/master/src/lib/syntax/lexer.rs#L219
The text was updated successfully, but these errors were encountered:
Hi @jasonwilliams I would like to take this up.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Rust 2018 edition removed the need for the
try
macro, functions which return an Option/Result can be used with the?
operator.More info here:
https://doc.rust-lang.org/stable/edition-guide/rust-2018/error-handling-and-panics/the-question-mark-operator-for-easier-error-handling.html
Book:
https://doc.rust-lang.org/beta/book/ch09-02-recoverable-errors-with-result.html#a-shortcut-for-propagating-errors-the--operator
Boa still has
try!
all over the place for e.g https://github.com/jasonwilliams/boa/blob/master/src/lib/js/value.rs#L507These could be converted to use the ? operator instead. e.g https://github.com/jasonwilliams/boa/blob/master/src/lib/syntax/lexer.rs#L219
The text was updated successfully, but these errors were encountered: