Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl: Remove hacks to get the supported locales of a service #3713

Open
Tracked by #3710
jedel1043 opened this issue Mar 2, 2024 · 1 comment
Open
Tracked by #3710

Intl: Remove hacks to get the supported locales of a service #3713

jedel1043 opened this issue Mar 2, 2024 · 1 comment
Labels
blocked Waiting for another code change Intl Changes related to the `Intl` implementation technical debt

Comments

@jedel1043
Copy link
Member

We currently have some hacks to be able to get the supported locales of certain services:

// TODO: ugly hack to accept locales that fallback to "und" in the collator/segmenter services
Some(loc)
if loc == candidate
|| (loc.is_empty()
&& [
CollationMetadataV1Marker::KEY.path(),
WordBreakDataV1Marker::KEY.path(),
]
.contains(&M::KEY.path())) =>
{

We should remove that when the proper APIs to fetch that information are available.

@jedel1043 jedel1043 added technical debt Intl Changes related to the `Intl` implementation labels Mar 2, 2024
@jedel1043
Copy link
Member Author

Blocked on unicode-org/icu4x/issues/58

@jedel1043 jedel1043 added the blocked Waiting for another code change label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting for another code change Intl Changes related to the `Intl` implementation technical debt
Projects
None yet
Development

No branches or pull requests

1 participant