Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce cargo fmt #43

Closed
jasonwilliams opened this issue Jun 30, 2019 · 1 comment
Closed

enforce cargo fmt #43

jasonwilliams opened this issue Jun 30, 2019 · 1 comment
Assignees
@jasonwilliams

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Jun 30, 2019 •
edited

It might be an idea to have this, so some PR's are formatting other PR's, it should make it easier for those reviewing.

https://github.com/rust-lang/rustfmt is here.

cargo fmt needs to be added to a commit hook. We can add something to CONTRIBUTING.md hinting that rustfmt needs to be installed by rustup component add rustfmt

potential example?

rust-lang/rust-analyzer#271
@jasonwilliams jasonwilliams self-assigned this Jun 30, 2019
@jasonwilliams
Copy link
Member Author

I can try to get Travis CI to check this

@jasonwilliams jasonwilliams changed the title Add cargo fmt to commit hook enforce cargo fmt Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonwilliams jasonwilliams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonwilliams