Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing strings #602

Closed
HalidOdat opened this issue Jul 31, 2020 · 1 comment
Closed

Indexing strings #602

HalidOdat opened this issue Jul 31, 2020 · 1 comment
Assignees
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request execution Issues or PRs related to code execution
Milestone

Comments

@HalidOdat
Copy link
Member

HalidOdat commented Jul 31, 2020

ECMASCript feature
Just like arrays you can also index the characters in a string.

Example code
This code should now work and give the expected result:

let x = "hello";
x[0]

The expected output is 'h'. the actual output is undefined.

This happens because the internal slots are not set for string objects. #591

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics execution Issues or PRs related to code execution labels Jul 31, 2020
@HalidOdat HalidOdat self-assigned this Jul 31, 2020
@HalidOdat HalidOdat linked a pull request Jul 31, 2020 that will close this issue
12 tasks
@Razican Razican added this to the v0.12.0 milestone Jan 11, 2021
This was referenced Jan 15, 2021
@Razican Razican modified the milestones: v0.12.0, v0.13.0 May 22, 2021
@RageKnify RageKnify modified the milestones: v0.13.0, v0.12.0 Jun 6, 2021
@RageKnify
Copy link
Member

I believe this was implemented in #1291, seems to be working as far as I can tell, if something is misisng we can open the issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants