Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating wasm-pack breaks with the latest version #99

Closed
jasonwilliams opened this issue Sep 8, 2019 · 1 comment
Closed

updating wasm-pack breaks with the latest version #99

jasonwilliams opened this issue Sep 8, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Sep 8, 2019 •
edited

What's happening:

undefined is returned

What should happen?:

`"1" should be returned

Ive also noticed boa_bg no longer gets outputed in pkg but index_bg instead.
Seems like wasm-pack has had quite a few changes recently

Steps to replicate:

  • clone project

  • yarn install

  • yarn serve

  • navigate to localhost:8080

  • Open up console and type evaluate("1")
    You should get "1" back, plus typing in the big box should work.

  • Now try updating wasm-pack to the latest version here
@jasonwilliams jasonwilliams added bug Something isn't working good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com labels Sep 8, 2019
@jasonwilliams jasonwilliams changed the title updating wasm-pack is breaks with the latest version :( updating wasm-pack breaks with the latest version Sep 9, 2019
@jasonwilliams
Copy link
Member Author

apparently its just a case of updating webpack

jasonwilliams added a commit that referenced this issue Sep 22, 2019
@jasonwilliams
fixes #99
4b7b331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonwilliams