Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Type" property in log causes conflict with Logstash #168

Open
rodhd opened this issue Mar 25, 2022 · 0 comments
Open

"Type" property in log causes conflict with Logstash #168

rodhd opened this issue Mar 25, 2022 · 0 comments

Comments

@rodhd
Copy link

rodhd commented Mar 25, 2022

Description

When inserting events into the repository, the generated logs use the a Type property:
MongoCommitRepository
Line 194
logger.LogError(e, "Error when saving a commit for {type} {id}", commit.AggregateType, commit.AggregateId);
and Line 203
logger.LogDebug("{Count} events for {Type} - {Id} handled. Result: {Result}.", commit.Events.Count, commit.AggregateType, commit.AggregateId, result.CommitId);

When using structured logs, the Type property is usually already in use by some data processing pipelines, in this particular Logstash, which then can cause errors.

Proposal

Rename the Type property to AggregateType to prevent such conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant