Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated demo on website #13

Closed
cdkrot opened this issue Jul 9, 2017 · 1 comment
Closed

Outdated demo on website #13

cdkrot opened this issue Jul 9, 2017 · 1 comment

Comments

@cdkrot
Copy link

cdkrot commented Jul 9, 2017

Just wanted to tell you, that you have a bug in demo on your website.

It is under "Simple API (Echo example)" section on "Getting started" page.

This is the compilation log:

a.c: In function ‘create_echo_protocol’:
a.c:45:19: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
.on_close = destroy_echo_protocol,
^~~~~~~~~~~~~~~~~~~~~
a.c:45:19: note: (near initialization for ‘(anonymous).on_close’)

And it really crashes when one tries to close connection to the server.

@boazsegev
Copy link
Owner

@cdkrot ,

Thank you so much! 🙏🏻

I guess that's what happens when development outpaces documentation. 😂

I assume you tested this with the stable branch.

I'll fix it soon ☺️👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants