Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

000006_Jazz Bass(2F)P.ini stange NoteLimitLow values #3

Closed
probonopd opened this issue Dec 2, 2023 · 5 comments
Closed

000006_Jazz Bass(2F)P.ini stange NoteLimitLow values #3

probonopd opened this issue Dec 2, 2023 · 5 comments
Assignees

Comments

@probonopd
Copy link

probonopd commented Dec 2, 2023

000006_Jazz Bass(2F)P.ini works only from middle D upwards and sounds differently from middle G upwards.

NoteLimitLowX is 61 for some voices and 67 for others.

Is this intentional?

@probonopd probonopd changed the title Jazz Bass(2F)P.ini stange NoteLimitLow values 000006_Jazz Bass(2F)P.ini stange NoteLimitLow values Dec 2, 2023
@BobanSpasic
Copy link
Owner

I see. The split points are like in the original file. The problem is that these channels should be muted.

@BobanSpasic BobanSpasic self-assigned this Dec 2, 2023
@probonopd
Copy link
Author

Interestingly, the demo at https://www.youtube.com/watch?v=Z2z9q8sh-5U&t=107s is also entirely silent and is skipped in that video.

@BobanSpasic
Copy link
Owner

The fix will be included in the next commit. It was a wrong processing of VoiceChannelOffset parameter, and not all the voices were muted that should be muted (the ones wit LowNote 67)

@probonopd
Copy link
Author

probonopd commented Dec 3, 2023

TX802 Jazz Bass is now silent from middle C downwards in c7e335b, is this like it should be? Hard to say, because it is skipped in the demo video for whatever reason.

@BobanSpasic
Copy link
Owner

Probably related to #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants