Leaderboard: hit the API #2
Conversation
There was a problem hiding this comment.
Hi @bobb-Rob 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- The Submit button hits the POST API point✔️
- The Refresh button hits the GET API point ✔️
- Use of arrow functions ✔️
- Use of
asyncandawaitkeywords along with thefetchfunction ✔️
Optional Suggestions
- Kindly consider the optional suggestions. 👍
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/index.js
Outdated
| const score = document.querySelector('#score-input'); | ||
|
|
||
| const newUserScore = { | ||
| user: name.value, | ||
| score: score.value, | ||
| }; |
There was a problem hiding this comment.
- [Optional] It would be nice to validate the name and score field so that a user won't be able to submit blank values. 👍
There was a problem hiding this comment.
Great Idea. I will do that right away. Thank you for this suggestion
src/index.js
Outdated
| .then((data) => getId(data.result)); | ||
|
|
There was a problem hiding this comment.
- [Optional] Everything in the application works properly. However, it would be nice to use one
gameIdfor your application. The reason I suggested this is that anytime I reload the page, all the scores are gone. This is because a newgameIdis fetched anytime I reload the page. For a good user experience, it would be great to have onegameId. You can put instructions in theREADME.mdfile to guide users on how to generate a newgameIdif a user wants to create a new game. 👍
|
@Gambit142 Thank you so much for the help. Kindly check to confirm I implemented all suggestions. |
Implemented the following: