Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oik/address block - wrong description in block.json #185

Closed
3 of 5 tasks
bobbingwide opened this issue Nov 5, 2021 · 1 comment
Closed
3 of 5 tasks

oik/address block - wrong description in block.json #185

bobbingwide opened this issue Nov 5, 2021 · 1 comment
Assignees
@bobbingwide
Labels
bug

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Nov 5, 2021 •
edited

For the oik/address block, in the block.json file the description should be "Displays your address".
It's currently got the value copied from oik-block/blockicon; "Displays a Block icon".

Solution

  • Correct the text
  • Rebuild... is this necessary?
  • Reinternationalize
  • Deliver new version
  • Update the relevant documentation.
@bobbingwide bobbingwide added the bug label Nov 5, 2021
@bobbingwide bobbingwide self-assigned this Nov 5, 2021
@bobbingwide
Copy link
Owner Author

Rebuild... is this necessary?

In this case it's not necessary to rebuild the JavaScript. The block editor sees the internationalized version of the description taken from the corrected block.json file, which is parsed and translated at run time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbingwide