Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: play sound when people is detected & stop it on conditions #51

Closed
mxmaxime opened this issue Aug 12, 2020 · 0 comments · Fixed by #59
Closed

feat: play sound when people is detected & stop it on conditions #51

mxmaxime opened this issue Aug 12, 2020 · 0 comments · Fixed by #59
Assignees
Labels
feature request Real feature for the end user
Projects
Milestone

Comments

@mxmaxime
Copy link
Collaborator

mxmaxime commented Aug 12, 2020

When a motion is detected, the system has to ring the alarm, basically "play a sound" for now.

When a motion is detected, we publish a message via mqtt, and the web app receives it.
This app have to publish another mqtt message to ring the alarm.

We should send this message via the web app because, in the future, we might add features like (when a people is here, just notify the resident, so don't ring the alarm, feature #38).

Then, when no motion is detected we publish a new message to stop the sound. It's not the same message as we might add some extra logic to stop the sound as:

  • wait a little bit to stop the sound.
  • give to the resident the possibility to stop the sound...

⚠️ It's a sensitive feature!

  • The sound has to stop when the alarm is switching to off. Don't even search if it's ringing, just publish to stop.
  • The sound has to stop after X seconds when a people was detected and then he's gone.
@mxmaxime mxmaxime added Web app Pull requests that update the Web app enhancement Improve internal stuffs labels Aug 12, 2020
@mxmaxime mxmaxime added this to To do in v0.1.0 via automation Aug 12, 2020
@mxmaxime mxmaxime added this to the First release milestone Aug 12, 2020
@mxmaxime mxmaxime self-assigned this Aug 12, 2020
@mxmaxime mxmaxime changed the title Feat: play sound when people is detected Feat: play sound when people is detected & stop it on conditions Aug 12, 2020
v0.1.0 automation moved this from To do to Done Aug 15, 2020
@mxmaxime mxmaxime changed the title Feat: play sound when people is detected & stop it on conditions feat: play sound when people is detected & stop it on conditions Sep 10, 2020
@mxmaxime mxmaxime added feature request Real feature for the end user and removed Web app Pull requests that update the Web app enhancement Improve internal stuffs labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Real feature for the end user
Projects
No open projects
v0.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant