Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo correction #79

Merged
merged 1 commit into from Jan 3, 2023
Merged

typo correction #79

merged 1 commit into from Jan 3, 2023

Conversation

roadsql
Copy link

@roadsql roadsql commented Jan 3, 2023

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

changed "If we wanted to the only the username and the email columns"
to "If we wanted to retrieve only the username and the email columns"

Related Tickets & Documents

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@roadsql
Copy link
Author

roadsql commented Jan 3, 2023

This is the first time I've ever contributed to someone else's project. This seems like a great resource and I'd like to be a regurlar contributor. I'm professor of Information systems at Brigham Young University and have taught database management since the late 1990s.

Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for taking the time and submitting this PR 🙌

That is amazing! It would be great to have you as a contributor! Any feedback will be highly appreciated!

@bobbyiliev bobbyiliev merged commit 9811178 into bobbyiliev:main Jan 3, 2023
@roadsql
Copy link
Author

roadsql commented Jan 3, 2023

I'm interested in making a version that uses Oracle as the underlying DB. Now that Oracle provides users with two databases in the cloud as a part of their free tier, I intent to start using that platform for teaching because students can readily use it as a resource in other classes (e.g. web dev). Does it make sense to chat about how to best accomplish that? Should I just make changes in a fork or would you like to bring that kind of content into the main project?

Could chat on zoom if you like...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants