Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #6 . Symbol match URL is a full path, e.g.
The
getMatchURL
copied fromstream.ts
gives us most of the same thing, and I was appending this URL to the match URL, creating an invalid URL. I could append this tosrc.instance
instead, but for consistency with content matches which append?${lineNumber}
, I've added a preprocessor to turnurl
into just the anchor link and append it to the match URL.Closes #6
Tested:
repo:github.com/sourcegraph/sourcegraph@rockskip-symbols type:symbol queryBlobs
context:@sourcegrapha/all monitoring type:symbol f:gcp