Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-2-4-linked-list, add tests accept the broken code #166

Open
obaibula opened this issue Apr 7, 2023 · 0 comments
Open

2-2-4-linked-list, add tests accept the broken code #166

obaibula opened this issue Apr 7, 2023 · 0 comments

Comments

@obaibula
Copy link

obaibula commented Apr 7, 2023

The broken code:

private void addAsHead(Node<T> newNode) {
        newNode.next = head;
        head = newNode;
}

Please consider the following example:

LinkedList<Integer> list = new LinkedList<>();
        list.add(0, 100);
        list.add(144);

This code will result in a NullPointerException if we define the add method as follows:

@Override
    public void add(T element) {
        requireNonNull(element);
        Node<T> newNode = new Node<>(element);

        if(head == null){
            head = tail = newNode;
        } else {
            tail.next = newNode;
            tail = tail.next;
        }
        size++;
    }

It's necessary to reassign tail, as shown in the "completed" branch.

@shryhus shryhus added this to To do in Java Fundamentals Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant