Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Support async callbacks in RoutingMiddleware #10

Closed
florimondmanca opened this issue Nov 20, 2018 · 0 comments · Fixed by #18
Closed

Support async callbacks in RoutingMiddleware #10

florimondmanca opened this issue Nov 20, 2018 · 0 comments · Fixed by #18
Labels
enhancement New feature or improvement of an existing one
Milestone
v0.6

Comments

@florimondmanca
Copy link
Member

florimondmanca commented Nov 20, 2018 •
edited
Loading

As it is now, RoutingMiddleware only allows synchronous callbacks (before_dispatch(), after_dispatch()) to be used.

This won't allow developers to call asynchronous code is said callbacks, such as perform an async HTTP request or even just consume the request body.

We need to add support for async callbacks too.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or improvement of an existing one
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

Check if route exists or method is allowed before running middleware/hooks alin23/bocadillo
1 participant
@florimondmanca