Ignore projects where emitting is disabled #15
Conversation
src/helpers.ts
Outdated
| return build_project_path(cwd, reference.originalPath!, referenceConfig); | ||
| }); | ||
| }).filter((project): project is TsProject => project !== null); |
There was a problem hiding this comment.
Maybe it would make sense to throw an error if at least one project doesn't have emitting enabled? 🤷
There was a problem hiding this comment.
Yes, maybe we should. But I'm not sure whether this should be stated as an error. What do you think about a yellow color_log message, and process.exit(0)?
I updated my answer, maybe a simple throw new Error is better, like how you mentioned.
|
@bencergazda anything I can do to help this along? |
|
Sorry, @nwalters512, I didn't have time to work on the project. I like the idea, and I'm happy to add this feature! However, I would be happy to be more explicit on handling this. We should rather handle this case in Then we could throw the errors both in |
|
@bencergazda thanks for taking a look at this! I made the requested changes. |
|
Thanks a lot! I merge it and bump a new version soon! |
Closes #14.
I did not make any changes to the non-
buildbranch of code (that is,get_ts_project_paths), as I figured it doesn't make any sense to use this package with a single project where emitting is disabled.