111 create a configure cluster command #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of points - happy to jump on a call to discuss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logic is good-to-go - we just need to get the naming sorted so that it makes sense.
We have two sets of entity that required service-accounts:
- pods running the workflow-controller (i.e. in a 'deployment job'); and,
- pods that form the stages of a workflow (be them jobs or k8s-deployment resources).
Prior to this PR, we have BODYWORK_WORKFLOW_SERVICE_ACCOUNT
for the first entity and BODYWORK_JOBS_DEPLOYMENTS_SERVICE_ACCOUNT
for the second.
We need to pick names that done't confuse in the future.
Codecov Report
@@ Coverage Diff @@
## v3.0.0 #113 +/- ##
=========================================
Coverage ? 97.90%
=========================================
Files ? 21
Lines ? 1383
Branches ? 0
=========================================
Hits ? 1354
Misses ? 29
Partials ? 0 Continue to review full report at Codecov.
|
Renaming has been done and added a test fixture that configures the cluster for the tests that require it. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor point and then good to go - doesn't need another review.
I have made the changes. I didn't add the |
Yes, that's right - if a deployment doesn't leave any services hanging around (i.e. just batch jobs), we should probably delete the namespace, too. |
This PR closes #111. Tweaked the existing code for setting up a namespace so the job-deployment accounts have permission to create namespaces. This in turn is called by the new command to configure the cluster.