Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider layout not behaving like the default Slider() #11

Closed
MrWaggel opened this issue Feb 4, 2019 · 1 comment
Closed

Slider layout not behaving like the default Slider() #11

MrWaggel opened this issue Feb 4, 2019 · 1 comment

Comments

@MrWaggel
Copy link

MrWaggel commented Feb 4, 2019

Problem:
When you put a RangeSlider() underneath a default Slider(), the width doesn't match.
before

Possible solution
In class file, change line 520
static const double _overlayDiameter = _overlayRadius * 2.0;
static const double _overlayDiameter = _overlayRadius;

and at line 733 under the void performResize() {} method to preserve the correct height
constraints.hasBoundedHeight ? constraints.maxHeight : _overlayDiameter,
constraints.hasBoundedHeight ? constraints.maxHeight : _overlayDiameter * 2,
after

But I'm not sure if it creates the wanted behavior for other cases, if you want I'll generate a pull request.

Awesome library and great documentation by the way my Wallonian friend, much appreciated!
Greetings from the north

@boeledi boeledi closed this as completed Feb 16, 2019
@boeledi
Copy link
Owner

boeledi commented Feb 16, 2019

Hi, I just released version 1.1.0 which now integrates your changes. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants