Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library must be loaded for parglm to work #2

Closed
ajdamico opened this issue Jan 9, 2019 · 2 comments
Closed

library must be loaded for parglm to work #2

ajdamico opened this issue Jan 9, 2019 · 2 comments

Comments

@ajdamico
Copy link

ajdamico commented Jan 9, 2019

hi, not sure if you care that users must always load the library..

fresh R session:

# works
glm( mpg ~ gear , data = mtcars )

# fails
parglm::parglm( mpg ~ gear , data = mtcars )
# Error in glm(formula = mpg ~ gear, data = mtcars, method = parglm.fit,  : 
  # object 'parglm.fit' not found
  
library(parglm)

# works
parglm( mpg ~ gear , data = mtcars )

thanks!

@boennecd
Copy link
Owner

boennecd commented Jan 9, 2019

Thanks. I should make a call here to parglm.fit or use quote(parglm::parglm.fit) instead

parglm/R/parglm.R

Lines 67 to 70 in c2cf5cd

cl <- match.call()
cl[[1L]] <- quote(glm)
cl[c("method", "singular.ok")] <- list(quote(parglm.fit), FALSE)
eval(cl, parent.frame())

@boennecd
Copy link
Owner

Fixed in 182490d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants