Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement collections_fetch() #11

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

ateucher
Copy link
Contributor

@ateucher ateucher commented Apr 8, 2024

Closes #10, but rather than a wrapper, implements our version of collections_fetch(). This would ideally live in rstac, but this implementation is useable now.

Issue open in rstac to add it there (though the implementation would be different in rstac as we could leverage internal methods)

@ateucher
Copy link
Contributor Author

ateucher commented Apr 8, 2024

Note: I've also exported edl_stac_urls() (#9), which I think is a handy function to have available to users.

Copy link
Member

@cboettig cboettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks @ateucher . Can you add yourself as a ctb in the DESCRIPTION and drop a comment in NEWS.md?

@ateucher
Copy link
Contributor Author

ateucher commented Apr 9, 2024

@cboettig some failures related to auth, but it looks like the EARTHDATA_USE and EARTHDATA_PASSWORD are set?

@cboettig
Copy link
Member

cboettig commented Apr 9, 2024

yeah the auth issue looks surprising, I need to take a look. maybe is related to secrets but I thought I had public credentials for this in place. no errors locally?

@cboettig
Copy link
Member

cboettig commented Apr 9, 2024

ah looks like I used encrypted secrets, and GitHub says:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

so should be fine once merged.

@cboettig cboettig merged commit 22afe13 into boettiger-lab:main Apr 9, 2024
1 of 6 checks passed
@ateucher
Copy link
Contributor Author

ateucher commented Apr 9, 2024

yeah the auth issue looks surprising, I need to take a look. maybe is related to secrets but I thought I had public credentials for this in place. no errors locally?

Yup, everything passed fine locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thin wrapper around rstac::collections() to automatically page the NASA STAC API?
2 participants