-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement collections_fetch()
#11
Conversation
Note: I've also exported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! thanks @ateucher . Can you add yourself as a ctb
in the DESCRIPTION and drop a comment in NEWS.md?
@cboettig some failures related to auth, but it looks like the |
yeah the auth issue looks surprising, I need to take a look. maybe is related to secrets but I thought I had public credentials for this in place. no errors locally? |
ah looks like I used encrypted secrets, and GitHub says:
so should be fine once merged. |
Yup, everything passed fine locally |
Closes #10, but rather than a wrapper, implements our version of
collections_fetch()
. This would ideally live in rstac, but this implementation is useable now.Issue open in rstac to add it there (though the implementation would be different in rstac as we could leverage internal methods)