Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help With Fiber #19

Closed
WillLuce opened this issue Sep 17, 2017 · 5 comments
Closed

Help With Fiber #19

WillLuce opened this issue Sep 17, 2017 · 5 comments

Comments

@WillLuce
Copy link
Contributor

WillLuce commented Sep 17, 2017

I issued the PR for some grammar fixes a few weeks ago. I'd like to do the same for your Fiber branch if you're ok with that. Let me know how I can help.

@Bogdan-Lyashenko
Copy link
Owner

Hey, thanks for your interest. Erm.. can you please check if I didn't miss anything, the last PR was like 2 months ago -
https://github.com/Bogdan-Lyashenko/Under-the-hood-ReactJS/pulls?q=is%3Apr+is%3Aclosed
Regarding Fiber, it's not ready yet, so branch is empty for now. Currently I work on library to automate flowchart drawing (it takes JS code - returns svg scheme) will use it for Fiber then, because it takes plenty of time to create that diagrams manually. So, when I finish that, we can proceed with Fiber. Thanks.

@Bogdan-Lyashenko
Copy link
Owner

@WillLuce, you can check out https://github.com/Bogdan-Lyashenko/js-code-to-svg-flowchart, it's not ready yet, but already can be used. I just don't think we should manually draw that flow-charts. Thanks.

@WillLuce
Copy link
Contributor Author

WillLuce commented Nov 2, 2017

Yep I’ll take a look tonight. Thanks for the invite.

@tsiq-swyx
Copy link

just checking in! a Fiber version of this would really be amazing!

@Bogdan-Lyashenko
Copy link
Owner

@tsiq-swyx, yeah.. need to find some time for that ;) currently busy with another repo. I think I definitely will do it, but probably in slightly different format, to have it smaller and more clear to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants