Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We have translation this repo into Chinese, do you consider add a ch-zn branch for Chinese version? #22

Closed
leviding opened this issue Oct 16, 2017 · 3 comments

Comments

@leviding
Copy link
Contributor

leviding commented Oct 16, 2017

You can see the Chinese Version at https://github.com/xitu/Under-the-hood-ReactJS/tree/translation.
PR 地址: #24

@Bogdan-Lyashenko
Copy link
Owner

@leviding nice, great work. Sure, I would be glad to add it. But can you please add it as one more language to the main branch (please check as korean was done). Thanks.

@leviding
Copy link
Contributor Author

leviding commented Oct 16, 2017

@Bogdan-Lyashenko Awesome! Well, we will check the translation again, guarantee the quality of translation. When we finish it, I will add it as one more language to the main branch. About 10 days later.

Bogdan-Lyashenko pushed a commit that referenced this issue Nov 2, 2017
ReactJS 底层揭秘(第 6 部分)
@Bogdan-Lyashenko
Copy link
Owner

thanks @leviding, awesome work! Merged, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants