Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should all the peerDependencies be optional? #128

Closed
NullVoxPopuli opened this issue Sep 19, 2022 · 4 comments
Closed

Should all the peerDependencies be optional? #128

NullVoxPopuli opened this issue Sep 19, 2022 · 4 comments

Comments

@NullVoxPopuli
Copy link

I saw that in the package.json, there are these peerDependenies entries:

  "peerDependencies": {
    "@angular-devkit/core": ">=11.0.1",
    "@angular-devkit/schematics": ">=11.0.1",
    "@nrwl/workspace": ">=9.2.2"
  },

Since I don't use angular, and since nx14 does not need @nrwl/workspace, can all of these peers be optional?

Related:

@bojanbass
Copy link
Owner

Hi. Thank you for reporting. Those are used only for backward NX compatibility, which was using those packages. Did you meant moving those dependencies to optionalDependencies or some other approach?

@jakemhiller
Copy link

Yeah, i'm interested in testing this out but I'm running into these errors. Might make sense to move them to optionalDependencies or remove them if that backwards compatibility isn't necessary anymore?

@jakemhiller
Copy link

actually, it looks like at least @angular-devkit/schematics is actually used in the plugin itself, so it can't be optional.

@bojanbass
Copy link
Owner

@angular-devkit was removed, please update to v2.0.0 and report if the issue is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants