Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghz-web convert timeunit error #181

Closed
forestbupt opened this issue Apr 21, 2020 · 1 comment
Closed

ghz-web convert timeunit error #181

forestbupt opened this issue Apr 21, 2020 · 1 comment
Assignees
Labels
WEB Issues for ghz-web

Comments

@forestbupt
Copy link

I believe there is a minor mistake in the function createChartData, it caused the time below 1ms always be displayed as 0, instead of x ns.

if (testValue > 1000000) {
unit = 'ms'
divr = 1000000
testValue = testValue / divr
}

if (testValue > 1000) { ######### it should be 1000000000 #########
unit = 's'
divr = 1000000000
}

@bojand bojand self-assigned this Apr 27, 2020
@bojand bojand added the WEB Issues for ghz-web label Apr 27, 2020
@bojand
Copy link
Owner

bojand commented May 13, 2020

Hello, thanks for reporting this. It should be addressed in 0.54.0. Feel free to reopen if there are issues.

@bojand bojand closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WEB Issues for ghz-web
Projects
None yet
Development

No branches or pull requests

2 participants