Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested package names #10

Closed
nunofgs opened this issue Dec 5, 2017 · 2 comments
Closed

Nested package names #10

nunofgs opened this issue Dec 5, 2017 · 2 comments
Assignees

Comments

@nunofgs
Copy link

nunofgs commented Dec 5, 2017

First of all, thank you for the great lib :)

I'm having issues with a package name that includes dots, such as:

package foo.bar;

service FooService {
  rpc DoSomething() returns () {}
}

When fetching the service names (grpcInspect(proto).serviceNames()) it returns an empty array.

Is this a bug?

@bojand bojand self-assigned this Dec 5, 2017
@codesword
Copy link

I am also having issues with this.

@bojand
Copy link
Owner

bojand commented Jan 18, 2018

Hello, this was actually addressed in 0.5.0. Here is the test proto as well as the actual test I forgot to reference it in this issue and close it. Please let me know if it's still an issue.

@bojand bojand closed this as completed Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants