Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outreachy Contribution for Adrian Orioki #26

Open
whoisorioki opened this issue Mar 16, 2023 · 1 comment
Open

Outreachy Contribution for Adrian Orioki #26

whoisorioki opened this issue Mar 16, 2023 · 1 comment

Comments

@whoisorioki
Copy link

whoisorioki commented Mar 16, 2023

Summary

I worked on Micro task : #6
I was able to visualize the dataset using Bokeh. I converted the datetime column to Unix timestamps which made it possible for me to find the durations between pick up and drop off times. I also found the speed since we have the distance of the trip. I made visualizations using the distance, speed, durations, pick up and drop off times.

Here is the link to my GitHub gist: https://gist.github.com/whoisorioki/e72c772832bdc0cc638f9ad8975057a7

@pavithraes
Copy link
Member

@whoisorioki Thank you for working on this microtask for your patience with our review. Your notebook looks great, and show how you've quickly familiarized yourself with Bokeh. :)

Some thoughts:

  • I think you've created some unique and interesting visualizations here, this is the first time I'm seeing the taxi speed visualized. :)
  • In your 2nd plot, titles "Histogram of pickup times" -- looks like we're plotting trip duration vs. frequency so I'd suggest updating the plot tile and x-axis label accordingly
  • In the 3rd plot "Heatmap of pickup locations" -- I don't know if the plot is showing what you intended? Please correct me if I'm wrong, I'd suggest the following updates to start with:
  • The last two plots seem like duplicates of previous ones, if that's the case I'd suggest removing them.

I liked the useful comments in your code, it made your work easy-to-follow. If you have the time, I'd encourage you to add some section headings for structure and notes about what you can infer from the plots for a story/flow in your notebook. :)

You've completed the microtask, please feel free to add this to your application after making any updates you see fit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants