Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh Project 1 Contribution by Khairat Ayinde #37

Open
khaiyra opened this issue Mar 23, 2023 · 2 comments
Open

Bokeh Project 1 Contribution by Khairat Ayinde #37

khaiyra opened this issue Mar 23, 2023 · 2 comments

Comments

@khaiyra
Copy link

khaiyra commented Mar 23, 2023

Hello @bryevdv @pavithraes here's my contribution to the Project: Fundamentals of Data Visualization in Bokeh.

Kindly review, thanks!

@bryevdv
Copy link
Member

bryevdv commented Mar 29, 2023

Hi @khaiyra thanks for your patience, I have been sick all week unfortunately. First, this notebook satisfies the requirements for the microtask.

Quick thoughts: I think you demontrate a good command of Bokeh APIs. In terms areas for attention, I think the plots Payment Type by Pickup Hour Donut Chart are the least compelling, it's not clear to me what they add in their present form. Also I note some warnings about CDS length mismatches. These usually indicate some issue with data preparation and good to follow up on and see what might be amiss.

@khaiyra
Copy link
Author

khaiyra commented Mar 29, 2023

Hi @bryevdv , sorry to hear that. I hope you are much better now?

Thanks for taking time to review and give your feedback, I would work on the data preparation ASAP and explore other charts that could more accurately represent the payment type by pickup hour. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants