Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

サインアウト時に適切でないフラッシュが出てしまう #282

Open
bokusunny opened this issue May 30, 2019 · 0 comments
Open

サインアウト時に適切でないフラッシュが出てしまう #282

bokusunny opened this issue May 30, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@bokusunny
Copy link
Owner

bokusunny commented May 30, 2019 •
edited
Loading

概要

サインアウト時にYou must be logged in to access this page.という不適切なフラッシュが出る(適切なフラッシュの上に被って出てきてしまう)

詳細

PrivateRouteのコンポーネントでサインアウト時に、https://github.com/bokusunny/Elaborate/blob/master/src/components/utils/private-route.tsx#L25-L29 に引っかかってしまうのが原因。そこに処理が行く前にLPにリダイレクトとかしたい

スクリーンショット

現状

スクリーンショット 2019-05-30 10 34 37

意図する挙動

スクリーンショット 2019-05-30 10 34 39
@bokusunny bokusunny added the bug Something isn't working label May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bokusunny