Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for native quoted strings #13

Merged
merged 1 commit into from
Jul 13, 2015

Conversation

edward
Copy link
Member

@edward edward commented Jul 13, 2015

Also refactors existing string-quoting stuff to use native quoted strings

For review @bolandrm

Also refactors existing string-quoting stuff to use native quoted strings
@bolandrm
Copy link
Member

@edward looks great. do we have any test coverage around how quoted strings / identifiers work? I don't see any, so changes to this are making me a little nervous

@edward
Copy link
Member Author

edward commented Jul 13, 2015

@bolandrm We do – most (if not all?) of the tests in functions_test.rb are testing this stuff.

I see a couple explicit tests like test_functions_may_return_sass_string_type and test_functions_work_with_varying_quotes_and_string_types – should we add some others?

@bolandrm
Copy link
Member

@edward oops! missed that =)

bolandrm added a commit that referenced this pull request Jul 13, 2015
Adds support for native quoted strings
@bolandrm bolandrm merged commit 9bde318 into sass:master Jul 13, 2015
@edward edward deleted the support-quoted-strings branch July 13, 2015 19:03
michael-gillett pushed a commit to michael-gillett/sassc-ruby that referenced this pull request Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants