Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New storage backend: OpenDAL #183

Closed
George-Miao opened this issue Jun 25, 2024 · 4 comments · Fixed by #184
Closed

New storage backend: OpenDAL #183

George-Miao opened this issue Jun 25, 2024 · 4 comments · Fixed by #184

Comments

@George-Miao
Copy link
Contributor

OpenDAL is a project that offers a unified data access layer for user. Recently I have implemented a SBE for opendal under integrations/unftp-sbe and would like to upstream the integration to unFTP binary. Feel free to comment on the implementation or point out any problem. I'm also willing to make a PR if it looks good to you.

@hannesdejager
Copy link
Collaborator

Oh wow, this seems nice, thanks @George-Miao

I think it makes sense the have the storage back-end in its own crate called unftp-sbe-opendal and then just pull that dependency into unFTP and add command line arguments to configure it, optionally hiding it behind a feature. This would be inline with our contribution request here: https://github.com/bolcom/libunftp/blob/master/CONTRIBUTING.md#developing-your-own-authentication-or-storage-back-end-implementation

We would love to see many of these emerge on crates.io to create an ecosystem of usable FTP building blocks for Rust. If we can ask that you prefix your crate names:

unftp-auth-* for authentication implementations
unftp-sbe-* for storage back-end implementations
Keeping this naming convention will allow a consistent and easy way for people to find libunftp extentions on crates.io

@George-Miao
Copy link
Contributor Author

If this looks good to you, should I proceed with the PR?

@Xuanwo
Copy link

Xuanwo commented Jun 26, 2024

That's fantastic! Users can now access additional storage services through opendal. Hopefully, this addresses the issue at bolcom/libunftp#342

@hannesdejager
Copy link
Collaborator

hannesdejager commented Jun 26, 2024

@George-Miao Yes lets do a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants