Added australian profiles and fixed few typos #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was producing the error below if you try to `import boltspy`.
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "%localappdata%\Local\Programs\Python\Python310\lib\site-packages\boltspy\__init__.py", line 26, in <module>
repo = blt.Repository(rootpath)
File "%localappdata%\Programs\Python\Python310\lib\site-packages\boltspy\bolttools\blt.py", line 289, in __init__
cls = Class(cl)
File "%localappdata%\Programs\Python\Python310\lib\site-packages\boltspy\bolttools\blt.py", line 134, in __init__
self.parameters = Parameters(cl.get("parameters",{"types" : {}}))
File "%localappdata%\Programs\Python\Python310\lib\site-packages\boltspy\bolttools\common.py", line 463, in __init__
table._normalize_and_check_types(self.types)
File "%localappdata%\Programs\Python\Python310\lib\site-packages\boltspy\bolttools\common.py", line 655, in _normalize_and_check_types
raise ValueError("Column is missing for row: %s" % key)
ValueError: Column is missing for row: M16
```
Previous name "Metric hexagon nut" already belongs to "hexagonnut1".
Without fix `import boltspy` was raising an error:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "%localappdata%\Programs\Python\Python310\lib\site-packages\boltspy\__init__.py", line 26, in <module>
repo = blt.Repository(rootpath)
File "%localappdata%\Programs\Python\Python310\lib\site-packages\boltspy\bolttools\blt.py", line 324, in __init__
raise MalformedRepositoryError("Duplicate name %s" % name.get_id())
boltspy.bolttools.errors.MalformedRepositoryError: Duplicate name MetricHexagonNut.
|
would it be possible to make two PRs, one for the changes on existing data and code and one for all the new additions of australian data. Review would much more simpler ... Do you know how to change commit messages afterwards? If yes would it be possible to start with one word which indicates what is the change about. Have a look at my commit messages. https://github.com/boltsparts/BOLTS/commits/master cheers bernd |
|
BTW: great to see this development :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added australian bluescope i-beam, c-beam, l-beam and hollow (circular, rectangular and squared) profiles. I was using Lysaght referee for the data reference - https://cdn.dcs.bluescope.com.au/download/the-lysaght-referee-35th-edition
Also fixed a few bugs/typos in current .blt profiles data that were causing exception during
import boltspy:546469d
Changed hexagonlocknut name to "Metric hexagon locknut" ad72346