Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Specify LockupTx confirmation target in reversesubmarine swap #264

Closed
joemphilips opened this issue Oct 26, 2021 · 2 comments · Fixed by #265
Closed

Feature Request: Specify LockupTx confirmation target in reversesubmarine swap #264

joemphilips opened this issue Oct 26, 2021 · 2 comments · Fixed by #265
Assignees
Labels
enhancement New feature or request

Comments

@joemphilips
Copy link
Contributor

When performing reverse submarine swap, it seems that intended behavior of the client is to claim from the lockuptx after 0 or 1 conf.

But I want to wait more for the sake of the security (especially when the on-chain asset is the one likely to reorg often), is it possible to specify a longer value?

In a loopout of the lightning loop, there is a parameter called htlc_confirmations
I could not find anything equivalent in a reverse submarine swap in the boltz.

Of course, I can still just wait for the confirmation without telling the boltz-backend server anything, but the invoice might expire in that case. So I want the server to change the expiration time of the invoice

(If I understand correctly, this is a reason that lightning loop imposes their acceptable range of the CLTV-delta for its invoice in case of a loop out, which can be seen in loop-cli terms command)

@michael1011 michael1011 self-assigned this Oct 26, 2021
@michael1011 michael1011 added the enhancement New feature or request label Oct 26, 2021
@michael1011
Copy link
Member

Our BTC/BTC reverse swaps have a 24 hour expiry as of right now but we don't expose that information via an API endpoint (yet; might be a good idea to do that). So waiting for a higher number of confirmations is surely possible.

Would an endpoint that shows you the expiration times of our swaps solve your issue?

@joemphilips
Copy link
Contributor Author

Would an endpoint that shows you the expiration times of our swaps solve your issue?

I think so. It is certainly better because I can just quit the swap before starting if the expiration is not acceptable.

It is nice if the value is set for each currency pairs, since how long we want to wait depends on how it is likely the on-chain asset is to reorg.

joemphilips added a commit to joemphilips/NLoop that referenced this issue Nov 2, 2021
* In LoopOut, the expected behavior of the client is to wait 0-or-1
  Confirmation, but this affects the security in the case of a reorg.
  So users should be able to specified the confimation.
* See also: BoltzExchange/boltz-backend#264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants