Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test configured #15

Merged
merged 3 commits into from Oct 26, 2022
Merged

Conversation

Xavier577
Copy link
Contributor

I have configured the test so we can import modules via the esm without any errors using babel and I have written test for generateVideoTag util function.

image

don't mind the redlines, that's eslint acting up on my editor but the test runs.

@bolubee101
Copy link
Owner

This is awesome man. Thank you. Just a couple of things.
Can you please move the tests to the test folder?
Also, in the jest config file, please remove all the commented-out scaffold code.

@Xavier577
Copy link
Contributor Author

yh sure I'll do that real quick

@bolubee101 bolubee101 linked an issue Oct 26, 2022 that may be closed by this pull request
Closed
@bolubee101
Copy link
Owner

Perfect. With the power bestowed on me, by myself, I hereby approve this PR in my name.

thumbs up

@bolubee101 bolubee101 merged commit a01d598 into bolubee101:main Oct 26, 2022
@Xavier577
Copy link
Contributor Author

🤩🤩🤩🤩

@deejinng
Copy link

Hoping to get to this kind of level some days 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests
3 participants