Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Object RadioNodeList element fix #6

Merged
merged 1 commit into from Mar 4, 2021

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Mar 4, 2021

HTMLFormElement.elements returns an HTMLFormControlsCollection, storing either RadioNodeLists or Elements.
This PR proposes a fix for the RadioNodeList case - it currently fails on theField.setAttribute (in updateForm).

To test, simply adds multiple inputs with the field name array syntax:

<label>Last name</label>
<input name="last_name[]">

<label>Last name</label>
<input name="last_name[]">

Thanks for this great library!

@bomsn bomsn merged commit 14918b3 into bomsn:master Mar 4, 2021
@bomsn
Copy link
Owner

bomsn commented Mar 4, 2021

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants