Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery icon is fuzzy #35

Closed
dac73 opened this issue Feb 25, 2020 · 25 comments
Closed

Battery icon is fuzzy #35

dac73 opened this issue Feb 25, 2020 · 25 comments
Assignees

Comments

@dac73
Copy link

dac73 commented Feb 25, 2020

image
Resolution: 1920x1200
Gnome: 3.34

@gusbemacbe gusbemacbe self-assigned this Feb 25, 2020
@gusbemacbe
Copy link
Collaborator

Hello @dac73 !

Thank you for reporting.

I who redesigned the battery icons, assigned myself for this.

@Bonandry, per favore, NON ridisegnare le icone di batteria. Io cho le ho ridisegnate. Lascia che me ne occupi io.

@btd1337 and @DarthWound

🇬🇧 Please check if the icon also seems fuzzy for your computer.
🇧🇷 Por favor verifiques se o ícone te parece desfocado no teu compuatdor.

@gusbemacbe
Copy link
Collaborator

@dac73

I understood that your monitor is Full HD. I will verify the folders.

@ghost
Copy link

ghost commented Feb 25, 2020

@gusbemacbe

Sorry I don't have any laptop, so I can't test. But as I said in #34 they redesigned the battery status icons in 3.34 maybe look at that. Looks like @dac73 uses an extension to show battery percentage, maybe it alters the icon too, ask him to try without extensions in order to troubleshoot.

PS: 1920x1200 isn't Full HD though, Full HD is 1920x1080. But it shouldn't matter here.

@dac73
Copy link
Author

dac73 commented Feb 25, 2020

It's the same on 1080p, also without percentage (which is set in gnome-tweaks).
image
Gnome shell theme is default.

@Drakkai
Copy link

Drakkai commented Apr 3, 2021

Screenshot from 2021-04-03 16-10-46
the problem still exists and only with battery icon
resolution: 1600x900
gnome: 3.38.5

@gusbemacbe
Copy link
Collaborator

@Drakkai

What was the battery percent?

gusbemacbe added a commit that referenced this issue Apr 8, 2021
@gusbemacbe
Copy link
Collaborator

Please, @dac73, @DarthWound and @Drakkai, test it.

@Drakkai
Copy link

Drakkai commented Apr 13, 2021

Screenshot from 2021-04-13 20-10-33
After update looks the same.

@gusbemacbe
Copy link
Collaborator

@Drakkai, strange, these icons are based on @SmartFinn's Papirus status battery icons.

@SmartFinn, analyse my battery design on Figma and select staus/16px page: https://www.figma.com/file/CaWjKZMjgPEFaUmPEfIz94O2/Adwaita-Part-1?node-id=32%3A2

@SmartFinn
Copy link

@gusbemacbe the icons should be 16px instead 48px. That why they are blurred.

@gusbemacbe
Copy link
Collaborator

@gusbemacbe the icons should be 16px instead 48px. That why they are blurred.

But they used to be 16px before and they were still fuzzy. I understood that fuzzy means blurry.

@gusbemacbe
Copy link
Collaborator

I found the problems, I'll follow the standard Papirus battery icons, @SmartFinn and @Drakkai.

  • Adwaita++ doesn't have panel/{16,22,24} that Papirus does.
  • Adwaita does not have 22px and 24px battery icons in the status folder
  • Comparing the Papirus battery icons, the Adwaita++ battery icons are wrong.

I will create a new folder panel and redevelop or redesign the Papirus battery icons in the Adwaita++ style.

gusbemacbe added a commit that referenced this issue Apr 19, 2021
@gusbemacbe
Copy link
Collaborator

gusbemacbe commented Apr 19, 2021

Please, test, using the branch beta, @Drakkai, Use Adwaita++ (not Adwaita++-Dark, and observe that battery icons are already white) and verify if it works for you.

If it works, I'll redesign cautiously the icons, following the standard Papirus battery icons.

@Drakkai
Copy link

Drakkai commented Apr 20, 2021

I've installed beta version with below command but it looks more like the default Adwaita.

wget -qO- https://raw.githubusercontent.com/Bonandry/adwaita-plus/beta/install.sh | TAG=beta sh

Screenshot from 2021-04-20 20-08-52

@gusbemacbe
Copy link
Collaborator

Do you mean the panel, @Drakkai?

In the window, the icons look more like Papirus icons.

@Drakkai
Copy link

Drakkai commented Apr 21, 2021

I mean the battery icon, but you may be right it's more like Papirus icon.

@gusbemacbe
Copy link
Collaborator

Please, can you test @SmartFinn's Papirus icon theme to see if the icon on the panel appears more like Papirus icon and if it's not buggy?

@Drakkai
Copy link

Drakkai commented Apr 23, 2021

Papirus icon:
Screenshot from 2021-04-23 21-40-23

@gusbemacbe
Copy link
Collaborator

Yes, I'll study it.

@gusbemacbe
Copy link
Collaborator

Hello @Drakkai

Please, test "Adwaita++" from the branch beta:

Adwaita++.zip

@Drakkai
Copy link

Drakkai commented May 12, 2021

this is what the icon looks like
Screenshot from 2021-05-12 22-16-42

@gusbemacbe
Copy link
Collaborator

Then the Papirus battery icons worked, does it seem buggy for you?

@gusbemacbe
Copy link
Collaborator

Hello @Drakkai

Now you can test the new version of Adwaita++ and Adwaita++ Dark. Report if it is still buggy. Just say me it is still bug or it is solved.

If you like the new design, I will close the thread. If you prefer the horizontal icon, I will make an alternative pack.

@Drakkai
Copy link

Drakkai commented May 16, 2021

Both versions look fine. Vertical design is OK :)

@gusbemacbe
Copy link
Collaborator

Great! I am going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants