You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for creating this CLI.
It is an enthusiast's dream to have this + local API to experiment with.
A few small behavior modifications for consideration:
When only 1 Bond Bridge exists and no bond is currently selected, running bond discover or bond select (without any params) could subsequently prompt the user to select that lone bridge. If this is not desired, bond list could at least print a small helper message to remind the user about the select command if they have none selected.
Output of bond list should show which Bond is currently selected.
Running bond select without any params causes it to exit without error or any clarifying output. I believe it might be due to this if statement not having an else to handle the case where bond_id is not provided.
Please let me know if these types of items are worth bringing up in issues or not so I don't create noise for your team.
The text was updated successfully, but these errors were encountered:
tariqbuilds
changed the title
Consider auto-selecting Bond if only 1 device found
Few small behavior update requests
Mar 29, 2020
Running bond select without any params causes it to exit without error or any clarifying output. [...]
This has since been fixed. Running select without arguments now displays the selected Bond:
> bond select
Bond selected: ZZDI37333
Regarding the suggestion 1, I think this needs a bit more elaboration.
I'm a bit against having bond discover automatically select a Bond, since this removes the option of discovering without selecting. Also, this goes against the principle in which each command should only do a single thing, avoiding collateral effects.
Thanks again for the suggestions, they are always welcome!
First of all, thank you for creating this CLI.
It is an enthusiast's dream to have this + local API to experiment with.
A few small behavior modifications for consideration:
When only 1 Bond Bridge exists and no bond is currently selected, running
bond discover
orbond select
(without any params) could subsequently prompt the user to select that lone bridge. If this is not desired,bond list
could at least print a small helper message to remind the user about theselect
command if they have none selected.Output of
bond list
should show which Bond is currentlyselected
.Running
bond select
without any params causes it to exit without error or any clarifying output. I believe it might be due to thisif
statement not having anelse
to handle the case wherebond_id
is not provided.Please let me know if these types of items are worth bringing up in issues or not so I don't create noise for your team.
The text was updated successfully, but these errors were encountered: