Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few small behavior update requests #36

Open
tariqbuilds opened this issue Mar 29, 2020 · 2 comments
Open

Few small behavior update requests #36

tariqbuilds opened this issue Mar 29, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tariqbuilds
Copy link

First of all, thank you for creating this CLI.
It is an enthusiast's dream to have this + local API to experiment with.

A few small behavior modifications for consideration:

  1. When only 1 Bond Bridge exists and no bond is currently selected, running bond discover or bond select (without any params) could subsequently prompt the user to select that lone bridge. If this is not desired, bond list could at least print a small helper message to remind the user about the select command if they have none selected.

  2. Output of bond list should show which Bond is currently selected.

  3. Running bond select without any params causes it to exit without error or any clarifying output. I believe it might be due to this if statement not having an else to handle the case where bond_id is not provided.

Please let me know if these types of items are worth bringing up in issues or not so I don't create noise for your team.

@tariqbuilds tariqbuilds changed the title Consider auto-selecting Bond if only 1 device found Few small behavior update requests Mar 29, 2020
@jdlambert
Copy link
Contributor

jdlambert commented Apr 1, 2020

Please let me know if these types of items are worth bringing up in issues or not so I don't create noise for your team.

They absolutely are worth bringing up! Thanks for the suggestions. I'll get these in pretty soon.

@jdlambert jdlambert self-assigned this Apr 1, 2020
@jdlambert jdlambert added the enhancement New feature or request label Apr 1, 2020
@fredericojordan fredericojordan self-assigned this Feb 22, 2022
@fredericojordan
Copy link
Contributor

  1. Output of bond list should show which Bond is currently selected.

This is a low-hanging fruit: #59

  1. Running bond select without any params causes it to exit without error or any clarifying output. [...]

This has since been fixed. Running select without arguments now displays the selected Bond:

> bond select
Bond selected: ZZDI37333

Regarding the suggestion 1, I think this needs a bit more elaboration.
I'm a bit against having bond discover automatically select a Bond, since this removes the option of discovering without selecting. Also, this goes against the principle in which each command should only do a single thing, avoiding collateral effects.

Thanks again for the suggestions, they are always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants