-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the dependency to sc.iview:sciview creates lots of duplicate classes #86
Comments
I believe some of these were fixed by @skalarproduktraum at the scenery level. In general, the solution should be to add exclusions at the scenery and/or sciview levels, so that downstream projects like bonej can just depend on sciview without any worries. |
I tried adding
like in scenery, but this didn't remove the errors about duplicate classes between |
You can use |
Hey guys, sorry for the late reply, I must have missed the notification. The root cause for this whole issue is JavaCL (and associates), which is not maintained anymore, but we needed to keep it in ClearCL for compatibility reasons. |
Would it make sense for each ClearCL backend to be its own artifact? So then you just depend on the backend of your choice as a dependency? Then people who don't need the JavaCL backend specifically wouldn't inherit those dependencies. Or do I misunderstand how ClearCL is intended to work? |
@skalarproduktraum
and the rendering window (with Vulkan) stopped appearing altogether. With OpenGL it shows, but is completely black (like before). The build errors reported above disappeared, but I got new ones:
I'll report what happens when I've get JDK 9 installed. With the scenery snapshot, should I also use the latest sciview snapshot? |
No, I've been trying to keep SciView attached to release versions of scenery only, now that more folks are starting to poke around at it. @skalarproduktraum was going to cut a release this or next week though. |
I have some comments, the last set of errors posted are missing the heading, because there still are duplicate classes. These seem to come from bridj which is pulling in com.google.android.tools:dx The bytecode enforcement seems to come from something going on in lwjgl: |
It looks like the enforcer is not special-casing the The |
Hi @rimadoma, @kephale and @ctrueden , the OpenGL bug has been fixed in a newer SNAPSHOT, it was actually just there for a few hours -- and you managed to get it! :-D Please only use the SNAPSHOT releases for testing, otherwise use the latest preview release version, which is 0.2.3 at the moment. The JDK9-related issue comes from an enforcer rule and is easy to fix in the pom, though. Have a look at scenerygraphics/sciview#63. The fixes for the duplicate class issues came after 0.2.3, so you'd have to stick with |
Fixed in 2fd5f21 with the right combo of exclusions. Analysis showed that the duplicate classes came from dependencies of sciview
and
|
@ctrueden @skalarproduktraum @kephale thanks for your help! |
@rimadoma Ideally, you would just depend on scenery and you wouldn't need to exclude anything. @skalarproduktraum @kephale Should we add these exclusions ( |
Adding dependency to the
sc.iview:sciview
towrapperPlugins
(in branch sciview) Maven artefact causes a massive list of duplicate dependency errors while trying to build the project (see list below).I've tried to add exclusions, for example
but they haven't helped.
The text was updated successfully, but these errors were encountered: