Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoneJ legacy tests abuse the GUI #14

Closed
rimadoma opened this issue May 4, 2016 · 3 comments
Closed

BoneJ legacy tests abuse the GUI #14

rimadoma opened this issue May 4, 2016 · 3 comments
Assignees
@rimadoma
Labels
enhancement

Comments

@rimadoma
Copy link
Contributor

rimadoma commented May 4, 2016

Because some unit tests in the legacy BoneJ code invoke the GUI, they cannot be run on the project's Jenkins server. Either make these tests integration tests, or use Mockito to mock the calls to GUI.
@rimadoma rimadoma changed the title BoneJ legacy tests abuse a GUI BoneJ legacy tests abuse the GUI May 4, 2016
@rimadoma rimadoma self-assigned this May 6, 2016
rimadoma pushed a commit that referenced this issue May 6, 2016
Fix issue #14
ca53db5
@rimadoma
Copy link
Contributor Author

rimadoma commented May 6, 2016

Fixed by mocking components that launched the GUI

@rimadoma rimadoma closed this as completed May 6, 2016
@rimadoma
Copy link
Contributor Author

rimadoma commented May 6, 2016

SMI and VolumeFraction still fail because they try to init java3d.VirtualUniverse

@rimadoma rimadoma reopened this May 6, 2016
rimadoma pushed a commit that referenced this issue May 6, 2016
Disable bad tests (Issue #14)
cf9a053
@rimadoma
Copy link
Contributor Author

rimadoma commented May 6, 2016

Finally fixed in commit cf9a053 - Jenkins build back to normal

@rimadoma rimadoma closed this as completed May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rimadoma rimadoma

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rimadoma