fix(proxy): handle props with falsy values

boneskull · Jan 31, 2018 · d2f80f4 · d2f80f4
1 parent dacaec1
commit d2f80f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -10,7 +10,7 @@ class PromiseModule {
 const handler = {
   get: (target, name) => {
     if (target.cache.has(name)) return target.cache.get(name)
-    if (target.mod[name]) {
+    if (name in target.mod) {
       let val
       if (typeof target.mod[name] === 'function') {
         val = (...args) => promisify(cb => target.mod[name](...args, cb))()

diff --git a/test/test-basics.js b/test/test-basics.js
@@ -28,3 +28,10 @@ test('unknown function', t => {
   let mod = promwrap(_module)
   t.throws(() => mod.foo())
 })
+
+test('falsy props', t => {
+  t.plan(1)
+  let mod = promwrap(_module)
+  _module.prop2 = false
+  t.same(mod.prop2, false)
+})