Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better query abstraction #115

Closed
jjl opened this issue Dec 14, 2021 · 1 comment
Closed

Better query abstraction #115

jjl opened this issue Dec 14, 2021 · 1 comment
Labels
dependencies Pull requests that update a dependency file Done In Progress

Comments

@jjl
Copy link
Contributor

jjl commented Dec 14, 2021

At the moment, there is an assortment of code of different ages for different parts of the system for managing queries. We rely on multiple existing macro based libraries to extend ecto.

Before I took a break from bonfire for a few months, i did much of the work on a new library called queery. Here is a snapshot of some user-level documentation I wrote for it: gist.

I propose to finish up this work now while I have to update some of this old code in the contexts anyway

@jjl jjl added the New Issue Please apply this label to any new issues :) label Dec 14, 2021
@jjl
Copy link
Contributor Author

jjl commented Dec 18, 2021

Rather too much learning about how ecto works later, i've concluded that while it's possible, it wouldn't be advisable since we'd have to rely on ecto internals or do incredibly bad things to make it work and the last thing i want to do is rewrite tons of code because ecto changes.

Accordingly i'm improving what we already have.

@jjl jjl added dependencies Pull requests that update a dependency file Done In Progress and removed New Issue Please apply this label to any new issues :) labels Dec 18, 2021
@mayel mayel closed this as completed Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Done In Progress
Projects
None yet
Development

No branches or pull requests

3 participants