Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Use prefers-color-scheme #451

Closed
Freeplayg opened this issue Sep 24, 2022 · 3 comments
Closed

Feature Proposal: Use prefers-color-scheme #451

Freeplayg opened this issue Sep 24, 2022 · 3 comments
Labels
New Issue Please apply this label to any new issues :)

Comments

@Freeplayg
Copy link

Is your feature request related to a problem? Please describe.
Sometimes I switch between light and dark mode on my desktop, and want the site to follow that

Describe the solution you'd like
Using prefers-color-scheme, preferably something similar to Misskey's theme switcher:
image

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme
https://developer.mozilla.org/en-US/docs/Web/API/Window/matchMedia

@Freeplayg Freeplayg added the New Issue Please apply this label to any new issues :) label Sep 24, 2022
@mayel
Copy link
Member

mayel commented Sep 24, 2022

Good idea, thing is we don't have just one dark and one light theme. Maybe we should have a user setting a preferred dark theme and a preferred light theme if the "sync / auto" option is on?

@mayel
Copy link
Member

mayel commented Sep 24, 2022

Maybe we should have a user setting a preferred dark theme and a preferred light theme if the "sync / auto" option is on?

Ah lol, just noticed that's what is done in the screenshot 👍

@mayel
Copy link
Member

mayel commented Sep 26, 2022

Done:
https://user-images.githubusercontent.com/115318/192189495-7892c6c6-123d-46b8-a5d3-6ede236bd98e.mov

mayel added a commit to bonfire-networks/bonfire_ui_me that referenced this issue Sep 26, 2022
mayel added a commit to bonfire-networks/bonfire_ui_common that referenced this issue Sep 26, 2022
@mayel mayel closed this as completed in 17eb5a7 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Issue Please apply this label to any new issues :)
Projects
None yet
Development

No branches or pull requests

2 participants