Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux challenge 7, potentially misleading text in test description #240

Closed
Pethaf opened this issue Oct 20, 2017 · 1 comment
Closed

Redux challenge 7, potentially misleading text in test description #240

Pethaf opened this issue Oct 20, 2017 · 1 comment

Comments

@Pethaf
Copy link

Pethaf commented Oct 20, 2017

The description says that the the reducer should return an object with the authenticated property set to either true or false. The test description says

Dispatching loginUser should update the login property in the store's state to true.
Dispatching logoutUser should update the login property in the store's state to false.

This is a bit missleading as test descriptions could be interpreted as stating that the reducer should return an object with a login property.

A simple fix would be to change the relevant test descriptions.

@bonham000
Copy link
Owner

@Pethaf yes I agree with you. Good job finding this, I've made the changes to these tests, feel free to take a look and open any new issues if you find something else. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants