Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: From github action, add label when PR are opened #456

Closed
benjaminParisel opened this issue Oct 24, 2022 · 3 comments
Closed

CI: From github action, add label when PR are opened #456

benjaminParisel opened this issue Oct 24, 2022 · 3 comments
Assignees
Labels

Comments

@benjaminParisel
Copy link
Contributor

When user open a PR in the documentation, they can't add label "Review needed" or add some reviewer.

It's a normal use-case because they are not a collaborator on this repository.

To by-pass this issue. I suggest adding the "review needed" label when PR is opened. We can do it by adding an action.

image

@tbouffard
Copy link
Member

tbouffard commented Oct 24, 2022

❓ I suppose this issue applies only to the bonita-doc repository, which is the only repository that use labels for review workflow. Is that right?

ℹ️ I suggest that when the PR is opened as a Draft, a WIP label is put instead.
The same should be done when switching from In Review to Draft and the opposite

ℹ️ when the PR status change from draft/in-review, put only the 'in review' label if there is no 'review done' or 'ready to merge' label already set

ℹ️ when the PR is mark as approved/rejected, we could also add the "review done" label, remove the "review needed" and add "ready to merge" or "changes requested"

⚠️ the label setting should work for PR created from forks like the one shown in the description (bonitasoft/bonita-doc#2204).
In this case, this is valid to run the workflow on pull_request_target as suggested in https://github.com/actions/labeler#create-workflow

ℹ️ for the list of event that could trigger the GH workflow, see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

@tbouffard tbouffard changed the title CI: From github action, add label when PR are open CI: From github action, add label when PR are opened Nov 7, 2022
@benjaminParisel benjaminParisel self-assigned this Mar 1, 2024
@benjaminParisel
Copy link
Contributor Author

After some research, we didn't find an action to manage all user flow mentioned in previous comments.

PR is opened as a Draft, a WIP label is put instead. 🚫 when A PR opened as a Draft, is obvious a WIP contribution, so we didn't label.
PR status change from draft/in-review ✔️ put only the **in review** label if there is no **review done** or **ready to merge** label already set
PR is mark as approved/rejected ✔️ Adding a Label **review done** instead of **in review** and **ready to merge** or **changes requested**

As much as we can, prepare a common job to allow re-usable flow in other documentation content.

@tbouffard tbouffard added the enhancement New feature or request label Mar 27, 2024
@benjaminParisel
Copy link
Contributor Author

This issue is not mandatory, the best practice, is to use the draft system.

So we close this issue.

@tbouffard tbouffard closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants