-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip win_unicode_console import for linux #9
Comments
I just checked, there is a better way to edit the requirements in setup.py using "Environment Markers" as specified in PEP-508: https://stackoverflow.com/a/54281345/4405656 |
I'd do this in the |
I've checked the code of |
Actually there is another issue related to win_unicode_console: it is not supported on Pypy (on Windows), and triggers an error. I will propose a change so that pcodedmp simply ignores it when win_unicode_console cannot be imported. |
I'll do it, at least based on the principle that I'd rather not install a module somewhere if I can avoid it, but even if you aren't using It's not just a configuration change, BTW. I'd have to modify the source of the main script too and not try to import or use the OK, I think I've made the necessary changes. Please try the |
Perfect, thanks very much! Keeping dependencies to a minimum in general is also a very good motive. And to anwer your question: for my own machine I could just do setup.py install. But I have to distribute the package to several machines and we are using rpm for that, so I have to create an rpm with a few modifications, which is quite a bit more effort. Issue solved for my part |
BTW: I've read your homepage and searched for other mentions of your name. I have learned a lot. Thanks for all your impressive work |
:) Yeah, I used to be a big name in the anti-virus field when I was young. Still got a few moves, though. :) OK, I won't be closing the issue just yet, because @decalage2 has some additional modifications in mind, in order to make the project compatible with PyPy. |
I propose to close this one and I'll open another one for the Pypy issue. It's related, but not the same. |
OK, closed. |
May I ask when you plan on merging this into master? |
I was waiting for @decalage2's modifications for PyPy compatibility. Merged now, version 1.2.6 released. |
I see. Thank you! |
I am a heavy user of oletools which now requires this module. I was wondering if you would object to wrapping all the win_unicode_console imports and requirements into a test whether the current platform actually is windows. I can create a pull request for this if you approve.
Specifically, in setup.py I would write
and similarly in pcodedmp.py I would write:
This would make the life of many oletools-linux-users easier
The text was updated successfully, but these errors were encountered: