Merge pull request #244 from akhilesh26/fix_proptype_warning

fix(propType warnings): remove isRequired and set default props to fix propType warnings.
metabrainz · Jan 25, 2019 · fba56f8 · fba56f8
2 parents b8a4166 + 6c4c588
commit fba56f8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/client/components/pages/entities/identifiers.js b/src/client/components/pages/entities/identifiers.js
@@ -56,8 +56,13 @@ function EntityIdentifiers({identifierSet, identifierTypes}) {
 
 EntityIdentifiers.displayName = 'EntityIdentifiers';
 EntityIdentifiers.propTypes = {
-	identifierSet: PropTypes.object.isRequired,
-	identifierTypes: PropTypes.array.isRequired
+	identifierSet: PropTypes.object,
+	identifierTypes: PropTypes.array
+};
+
+EntityIdentifiers.defaultProps = {
+	identifierSet: {},
+	identifierTypes: []
 };
 
 export default EntityIdentifiers;
diff --git a/src/client/components/pages/entities/image.js b/src/client/components/pages/entities/image.js
@@ -47,7 +47,10 @@ function EntityImage({backupIcon, imageUrl}) {
 EntityImage.displayName = 'EntityImage';
 EntityImage.propTypes = {
 	backupIcon: PropTypes.string.isRequired,
-	imageUrl: PropTypes.string.isRequired
+	imageUrl: PropTypes.string
 };
 
+EntityImage.defaultProps = {
+	imageUrl: ''
+};
 export default EntityImage;