Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide deprecated relationships in relationship editor #283

Merged
merged 3 commits into from Nov 29, 2019

Conversation

MonkeyDo
Copy link
Contributor

@MonkeyDo MonkeyDo commented May 9, 2019

Like it says on the tin !

A cleanup SQL script is needed to convert those Edition-Edition Group relationships to the Edition Group property of an Edition

@coveralls
Copy link

coveralls commented May 9, 2019

Coverage Status

Coverage increased (+0.06%) to 40.37% when pulling 8452660 on hide-deprecated-relationships into a6d2602 on master.

@MonkeyDo
Copy link
Contributor Author

Hi @LordSputnik !
I'd love your opinion and a second pair of eyes on the sql script.
The idea is to replace all the deprecated Edition <-> Edition Group relationships with edition.edition_group, and delete the deprecated relationships from the entities' current relationship sets.

What do you think about this approach? Is that what you had in mind?

@MonkeyDo MonkeyDo requested a review from LordSputnik May 13, 2019 12:08
…nships for this entity type

Also fix entity type display for Edition Groups in relationship editor
@MonkeyDo MonkeyDo merged commit 0ec1bfa into master Nov 29, 2019
@MonkeyDo MonkeyDo deleted the hide-deprecated-relationships branch November 29, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants