Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document local setup and debugging with VSCode #320

Merged
merged 4 commits into from
Nov 28, 2019

Conversation

MonkeyDo
Copy link
Contributor

Problem

image

Solution

Reworked the instructions, and published .vscode files

Areas of Impact

Just the markdown repo docs

& move the running webpack in live-reload instructions to a more appropriate section
@MonkeyDo
Copy link
Contributor Author

@sbvkrishna and @panwarabhishek345 , considering you both have fresh eyes on this, and are both interested in the content, could you please have a look at this PR and tell me if anything needs to be changed improved?

@coveralls
Copy link

coveralls commented Nov 15, 2019

Coverage Status

Coverage remained the same at 43.014% when pulling 9a4f180 on document-local-setup into 3ed88ff on master.

@panwarabhishek345
Copy link
Contributor

@MonkeyDo Will have a look at it soon.

NODEJS_SETUP.md Outdated Show resolved Hide resolved
Co-Authored-By: Krishna <saladibalavijayakrishna@gmail.com>
@sbvkrishna
Copy link
Contributor

Everything looks great! 👌

And correct ticket tracker link
@MonkeyDo MonkeyDo merged commit d47b2fc into master Nov 28, 2019
@MonkeyDo MonkeyDo deleted the document-local-setup branch November 28, 2019 20:27
anirudhjain75 pushed a commit to anirudhjain75/bookbrainz-site that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants